Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames are removed from accounts.aof with clean save #1637

Open
2 of 3 tasks
J-295 opened this issue Jan 27, 2024 · 3 comments · May be fixed by #1629
Open
2 of 3 tasks

Usernames are removed from accounts.aof with clean save #1637

J-295 opened this issue Jan 27, 2024 · 3 comments · May be fixed by #1629

Comments

@J-295
Copy link
Member

J-295 commented Jan 27, 2024

Expected behavior

When the accounts.aof file is rewritten due to >= 10% of lines being modifications, the comments containing the Discord and Minecraft usernames should remain.

Actual behavior

Only the identifiers are included in the new file contents, the comments are removed.

Steps to reproduce

Start the server with an accounts.aof file where 10% or more of the lines are modifications to cause the file to be rewritten.

Server software and version

No response

Checks

  • I am not using an outdated version of DiscordSRV.
  • I asked in DiscordSRV's Discord server to see whether this issue is in fact a bug that needs to be fixed.
  • I didn't actually check any of these things
@J-295 J-295 added the bug label Jan 27, 2024
@Vankka
Copy link
Member

Vankka commented Apr 24, 2024

I'm not sure we even should be writing usernames in the aof file. Usernames can be changed so that information will become invalid unless we also update it, which then defeats the purpose of it being a "append only" file

@Scarsz
Copy link
Member

Scarsz commented Apr 25, 2024

I'm not sure we even should be writing usernames in the aof file. Usernames can be changed so that information will become invalid unless we also update it, which then defeats the purpose of it being a "append only" file

I added them in to make ctrl+F'ing to find entries easier but I agree they're not really worth the hassle of maintaining

@granny granny added the fixed label May 15, 2024
@granny granny linked a pull request May 15, 2024 that will close this issue
@granny
Copy link
Member

granny commented May 15, 2024

Comments in the .aof file have been removed for consistencies sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants