You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the accounts.aof file is rewritten due to >= 10% of lines being modifications, the comments containing the Discord and Minecraft usernames should remain.
Actual behavior
Only the identifiers are included in the new file contents, the comments are removed.
Steps to reproduce
Start the server with an accounts.aof file where 10% or more of the lines are modifications to cause the file to be rewritten.
I'm not sure we even should be writing usernames in the aof file. Usernames can be changed so that information will become invalid unless we also update it, which then defeats the purpose of it being a "append only" file
I'm not sure we even should be writing usernames in the aof file. Usernames can be changed so that information will become invalid unless we also update it, which then defeats the purpose of it being a "append only" file
I added them in to make ctrl+F'ing to find entries easier but I agree they're not really worth the hassle of maintaining
Expected behavior
When the accounts.aof file is rewritten due to >= 10% of lines being modifications, the comments containing the Discord and Minecraft usernames should remain.
Actual behavior
Only the identifiers are included in the new file contents, the comments are removed.
Steps to reproduce
Start the server with an accounts.aof file where 10% or more of the lines are modifications to cause the file to be rewritten.
Server software and version
No response
Checks
The text was updated successfully, but these errors were encountered: