Advancements are named after their file name not their title

[lerokko]

Expected behavior

DiscrodSRV uses the "title" in custom advancements for their message. To have parity with how the vanilla chat would display it.

Actual behavior

I have a custom advancement called root.json with the title "Welcome to the Server". DiscordSRV used to use this title for the advancement message but in the latest snapshot under 1.20.2 (paper-241) its seem to use the file name and make the first letter upper case "Root" (note that the word "Root" is nowhere in the json its just the file name.)

Steps to reproduce

Get the latest paper for 1.20.2 241 and discordSRV snapshot fdcb09f
Add the example datapack to the server. The advancement should be automatically granted on join and show up in chat and the advancement tab.
EDIT 2024: Uploaded the file to github so I can finally stop self-hosting it, lol. I did not know you could attach files to comments server26advancements_discordsrvtest.zip

Server software and version

git-Paper-241 (MC: 1.20.2)

Checks

• I am not using an outdated version of DiscordSRV.
• I asked in DiscordSRV's Discord server to see whether this issue is in fact a bug that needs to be fixed.

Anything else

No response

[comicsansgreenki]

Issue seems present in two servers with stable build (1.26.2) - except they're vanilla advancements.

[13:35:58 INFO]: comicsansgreenki issued server command: /advancement grant @s only minecraft:nether/return_to_sender
[13:35:59 INFO]: comicsansgreenki has completed the challenge [Return to Sender]
[13:35:59 INFO]: [comicsansgreenki: Granted the advancement [Return to Sender] to comicsansgreenki]
[13:35:59 INFO]: [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Failed to get title of advancement nether/return_to_sender: Failed to find AdvancementDisplay getter for advancement handle
[13:37:24 INFO]: comicsansgreenki issued server command: /advancement grant @s only minecraft:story/deflect_arrow
[13:37:24 INFO]: comicsansgreenki has made the advancement [Not Today, Thank You]
[13:37:24 INFO]: [comicsansgreenki: Granted the advancement [Not Today, Thank You] to comicsansgreenki]
[13:37:24 INFO]: [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Failed to get title of advancement story/deflect_arrow: Failed to find AdvancementDisplay getter for advancement handle

[comicsansgreenki]

Also present in 1.27.0-SNAPSHOT-b3a177f.

[13:57:04 INFO]: comicsansgreenki issued server command: /advancement grant @s only minecraft:story/deflect_arrow
[13:57:04 INFO]: comicsansgreenki has made the advancement [Not Today, Thank You]
[13:57:04 INFO]: [comicsansgreenki: Granted the advancement [Not Today, Thank You] to comicsansgreenki]
[13:57:04 INFO]: [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Failed to get title of advancement story/deflect_arrow: Failed to find AdvancementDisplay getter for advancement handle

[TheUnknownCod3r]

I asked about this in the discord almost 2 months ago, and got no answer regarding, so good to know which plugin was at issue finally. We had no errors in the console or logs.

[comicsansgreenki]

yayyy! tysm @Scarsz @granny <3

[AAlchemy]

Sorry to necro a close issued, but this problem is back with build 1.27.0 on paper 1.20.4-389
Player has made the advancement Form Obsidian!

[granny]

@AAlchemy fixed again in snapshot builds, https://snapshot.discordsrv.com/