Naming of XChannelEditSpec.Builder#addPermissionOverwrite is potentially confusing #1010
Labels
area/core
Related to core module: events, entities, clients, specs
feature-request
Request for a new library feature or behavior
Milestone
Feature Description:
Modify the
channel#addPermissionOverwrite
method to internally fetch a list of all existing permission overwrites, add the one provided, and send the whole package to discord. This is opposed to current behaviour which is nearly the same aschannel#addAllPermissionOverwrites
except it only sends the one provided, deleting all others.Justification:
At the moment, the
textChannel#addPermissionOverwrite
method will send an empty set with only the single specified permission overwrite to discord. By instead fetching all existing overwrites, adding the one provided, and sending the entire set, the method will be true to its name and will not delete all other existing overwrites. This will also make modifying channel permissions much simpler as the user would not have to get the list, create a new one with the added overwrite, and send them all manually.The text was updated successfully, but these errors were encountered: