Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category management #69

Open
naglepuff opened this issue Jan 4, 2024 · 7 comments
Open

Category management #69

naglepuff opened this issue Jan 4, 2024 · 7 comments
Assignees

Comments

@naglepuff
Copy link
Collaborator

naglepuff commented Jan 4, 2024

Use cases:

  • Delete category + unlabel
  • Merge category
@jagstein
Copy link

jagstein commented Jan 4, 2024

. it would be helpful to have a single source of truth (e.g. a .yaml file) that can be edited using the UI, hand edited, or moved between projects.
. Category management should be available in the Initial Labeling task
. Unclear whether category management is needed during the Active Learning / Improve Predictions task
. Likely need to build a dedicated UI/task for managing categories

What information do we need about each category?
. key -- internal value generated by HistomicsUI -- unchangeable. If users are adding a category by editing the .yaml, they should leave this blank and then HistomicsUI generates a key
. Full title
. Short title for display
. Edge color & thickness
. Fill color & opacity
. hotkey --> (if people are editing by hand unclear how we would prevent collisions)
. order (if people are editing by hand and the categories are given the same order, we can alphabetize)
. ??? anything else

@bnmajor bnmajor self-assigned this Feb 5, 2024
@jagstein
Copy link

jagstein commented Feb 6, 2024

Categories still randomly switching in the initial labeling task
I labeled 100s of patches including many marker (see below) which are no longer being counted??

Image

@bnmajor
Copy link
Collaborator

bnmajor commented Feb 6, 2024

@jagstein Is this happening with the latest changes on master? And if so are you seeing the config file that should have been created in the project directory?

@jagstein
Copy link

jagstein commented Feb 7, 2024

That was the old version. Haven't seen that with the new version. I have seen this:

Hotkey reverts when trying to set a new hotkey:

Image

Image

Image

@bnmajor
Copy link
Collaborator

bnmajor commented Feb 7, 2024

@jagstein Thanks for the update!

To set the hotkeys you will need to:

  • Press "enter" once you've set the new hot key you'd like to use. If the value is still in italics the change has not been committed.
  • Press the check mark to accept all changes (hot key use will be prevented until you're done making changes)

If you are doing both of these steps and still seeing issues though please let me know!

@jagstein
Copy link

Squirrely .yamls:
. Project A is going well, has been trained and retrained a few times.
. Project B is new. Slides uploaded.
. Project B shares some categories with project A. I copy over the .yaml and then delete the unneeded categories.
. Start initial labeling task in project B --> unneeded categories appear in the list.
. Look at .yaml for project B --> file has duplicated, categories are back
. Delete categories in .yaml. save.
. Exit yaml and recheck - categories are still gone.
. Go to labeling task for project B --> unneeded categories are back
. Look at .yaml for project B --> file has duplicates, categories are back

@bnmajor
Copy link
Collaborator

bnmajor commented Feb 28, 2024

@jagstein I'm very sorry, I'm not sure why I missed this comment!

Before the latest labeling changes were merged in there was no way to delete categories, including through the config file so once a category existed it was there forever. Master now has the delete and merge features that I demoed at the last meeting so if you pull the latest changes again you will be able to remove these categories through the UI.

Even without the option to delete though I see a few other things that could be bugs:

. Project B shares some categories with project A. I copy over the .yaml and then delete the unneeded categories.
. Start initial labeling task in project B --> unneeded categories appear in the list.

It sounds like you copied the yaml and deleted the unneeded categories before you opened the UI to start the initial labeling. In that case those extraneous categories should not have even been created. Is it possible that you opened the UI before you deleted the categories? And if not, did you open project B in the Histomics UI or some other way? I am trying to figure out where it may have picked up the extra categories from...

. Look at .yaml for project B --> file has duplicated, categories are back
...
. Look at .yaml for project B --> file has duplicates, categories are back

There should definitely not be duplicates. To clarify - are you saying there is a duplicate file? Or that there are duplicate categories in the file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants