Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The miner is mining a drop that's already claimed #334

Open
zelda0079 opened this issue Oct 24, 2023 · 6 comments
Open

The miner is mining a drop that's already claimed #334

zelda0079 opened this issue Oct 24, 2023 · 6 comments
Labels
Bug Something isn't working

Comments

@zelda0079
Copy link



But it only occurs on fishing planet twitch drop.

@zelda0079 zelda0079 changed the title The miner idle the drop which is got The miner idle the drop which was gotten Oct 24, 2023
@DevilXD
Copy link
Owner

DevilXD commented Oct 24, 2023

Hello there o/

This is weird. Are you sure you are logged in on the same account, both in the browser and the miner?

@DevilXD DevilXD added the Help / Issue General or specific issues that just require some additional assistance to solve label Oct 24, 2023
@This-Person
Copy link

This-Person commented Oct 25, 2023

This is happening to me too with PUBG, I've claimed the Varsity Jacket and 2 Contraband Coupons but it keeps trying to mine them again. Definitely signed into the same account.

If i close the app and re-open it it clears the progress the miner thinks it has made (e.g. the miner had the Contraband Coupon at 18% just now, I closed the app and re-opened it and it started from 0% again)

@scryptio
Copy link

I am getting this, too for several drop campaigns. This might be related to #301 and the current twitch changes. Their site got a problem, too I guess because currently progress can only be viewed (for recent drops as it seems) in the Inventory and not via the Profile Container top right anymore.

@DevilXD
Copy link
Owner

DevilXD commented Oct 25, 2023

Drop claim status isn't easily deterministic, based only on the inventory. A campaign isn't returned by the inventory, if it isn't started yet - only the campaigns page returns it. Once it's started, it appears in the inventory, with progress attached to it (self edge). Once it's finished, it disappears from the inventory again, and goes back to existing only in the campaigns page. This means there's no real difference between a campaign which isn't started yet, and one that has been already finished.

To determine between these two states, I use the list of benefits claimed recently, and assume that if a benefit is claimed while a campaign was active at the time, then the drop can be marked as claimed too. This could potentially mark unclaimed drops as claimed though, but not the other way around. Ref comment from the code:

picture

I'll take a closer look at this logic, once the new campaigns estabilish themselves more and more. Right now, I'm still seeing the old kind of campaigns being available, so don't really have anything reliable to test on.

@DevilXD DevilXD changed the title The miner idle the drop which was gotten The miner is mining a drop that's already claimed Oct 25, 2023
@DevilXD DevilXD added Bug Something isn't working and removed Help / Issue General or specific issues that just require some additional assistance to solve labels Oct 25, 2023
@DevilXD
Copy link
Owner

DevilXD commented Nov 4, 2023

I took a look at this, and there doesn't seem to be anything out of order. Please ensure you're using the latest dev version of the miner. If this issue appears again, I'd like to see your inventory page and how's the progress displayed there vs in the miner.

@DevilXD
Copy link
Owner

DevilXD commented Dec 16, 2023

Does this issue still happen to anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@DevilXD @zelda0079 @scryptio @This-Person and others