Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Krona-LCA from workflow and required databases #148

Open
florianzwagemaker opened this issue Jun 2, 2020 · 0 comments
Open

Remove Krona-LCA from workflow and required databases #148

florianzwagemaker opened this issue Jun 2, 2020 · 0 comments
Assignees
@DennisSchmitz @florianzwagemaker
Labels
enhancement New feature or request
Milestone
0.9.8

Comments

@florianzwagemaker
Copy link
Collaborator

florianzwagemaker commented Jun 2, 2020 •
edited by DennisSchmitz

The Krona-LCA gives errors like marbl/Krona#137 and marbl/Krona#139. We also see it in our logs. Since we already have an LCA method via MgKit, which produces an LCA with "better" results... we don't actually need the Krona-specific LCA.

All we need is the script that creates the Krona-chart, which is compatible with the LCA generated by MgKit. I'd suggest it's best to simply remove it.
@florianzwagemaker florianzwagemaker added the enhancement New feature or request label Jun 2, 2020
@florianzwagemaker florianzwagemaker added this to the 0.9.8 milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DennisSchmitz DennisSchmitz

@florianzwagemaker florianzwagemaker

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.8
Development

No branches or pull requests
2 participants
@DennisSchmitz @florianzwagemaker