Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assuming logical $PATH configurations of end-users #137

Open
DennisSchmitz opened this issue Apr 28, 2020 · 0 comments
Open

Stop assuming logical $PATH configurations of end-users #137

DennisSchmitz opened this issue Apr 28, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DennisSchmitz
Copy link
Owner

We should stop assuming that the user's $PATH is correct when executing stuff from within a conda env. Likewise, we should stop hard-coding software location with shebangs. Usually this functions properly, but when it doesn't, it's a nightmare to debug. Especially since we are now running Jovian on many different hardware setups, different distros, secured environments and even WSL1.

In the next code review we should:

  • Add the following before every executable that is performed from within a conda env: ${CONDA_PREFIX}/bin/PROGRAM_NAME
  • Remove every shebang and simply specify it with the above syntax when executing the command/script.
@DennisSchmitz DennisSchmitz added the enhancement New feature or request label Apr 28, 2020
@DennisSchmitz DennisSchmitz added this to the 0.9.7 milestone Apr 28, 2020
@DennisSchmitz DennisSchmitz self-assigned this Apr 28, 2020
DennisSchmitz added a commit that referenced this issue Apr 28, 2020
@DennisSchmitz DennisSchmitz modified the milestones: 0.9.7, 0.9.8 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
general enhancements
  
Awaiting triage
Development

No branches or pull requests

1 participant