Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken github-release.py needs to be fixed #1467

Closed
Jingru923 opened this issue May 14, 2024 · 1 comment · Fixed by #1492
Closed

Broken github-release.py needs to be fixed #1467

Jingru923 opened this issue May 14, 2024 · 1 comment · Fixed by #1492
Assignees
Labels
blocker Someone should do this ASAP bug Indicates an unexpected problem or unintended behavior CI/CD Continuous Integration/Continuous deployment

Comments

@Jingru923
Copy link
Contributor

In our automated release process, when a tag that starts with v20 are made, TeamCity will start the automated release process.
When I was about to make a release, it didn't happen because the tag can't be detected. This is a result of previous changes in file github-release.py. This needs to be fixed

@Jingru923 Jingru923 added CI/CD Continuous Integration/Continuous deployment bug Indicates an unexpected problem or unintended behavior labels May 14, 2024
@visr
Copy link
Member

visr commented May 14, 2024

Specifically the current_git_branch function seems to just return HEAD.
I'm not sure why rev-parse was used here, but git describe --tags --exact-match, which is already used in that script, should be fine to check if we are on a tag starting with v20.

https://github.com/Deltares/Ribasim/blob/v2024.8.0/utils/github-release.py

@visr visr added the blocker Someone should do this ASAP label May 17, 2024
@Jingru923 Jingru923 assigned Jingru923 and visr and unassigned Jingru923 May 23, 2024
Jingru923 pushed a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Someone should do this ASAP bug Indicates an unexpected problem or unintended behavior CI/CD Continuous Integration/Continuous deployment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants