Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using audio/wav is throwing an error #100

Open
AsemKakhi opened this issue Jun 2, 2022 · 2 comments
Open

Using audio/wav is throwing an error #100

AsemKakhi opened this issue Jun 2, 2022 · 2 comments

Comments

@AsemKakhi
Copy link

AsemKakhi commented Jun 2, 2022

You already using the extendable-media-recorder library as a dependency, which adds the support of using "audio/wav" for audio recording.
but this line of code is throwing an error when I set the { mimeType: "audio/wav"}

if (!MediaRecorder.isTypeSupported(mediaRecorderOptions.mimeType)) {
  console.error(
    `The specified MIME type you supplied for MediaRecorder doesn't support this browser`,
  );
}

because "audio/wav" is not natively a supported format by the browser

Please consider fixing this
I would suggest something like:

if (!MediaRecorder.isTypeSupported(mediaRecorderOptions.mimeType) && mediaRecorderOptions.mimeType.toLowerCase() !== "audio/wav") {
  console.error(
    `The specified MIME type you supplied for MediaRecorder doesn't support this browser`,
  );
}
@StianHaugland1
Copy link

StianHaugland1 commented Jun 15, 2022

We have the same issue

@santiarr
Copy link

Facing this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants