Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of vorticity #91

Open
Niceno opened this issue Dec 2, 2018 · 2 comments
Open

Calculation of vorticity #91

Niceno opened this issue Dec 2, 2018 · 2 comments
Labels
question Further information is requested

Comments

@Niceno
Copy link
Collaborator

Niceno commented Dec 2, 2018

Dear guys,

In T-Flows, vorticity is calculated in two subroutines: Calculate_Vorticity and Calculate_Shear_And_Vorticity. I thought that one was too much, but by looking into them, I realized that vorticity is not calculated in the same way in each of these functions 😨

Which one is correct? What shall we do?

@Niceno Niceno added the question Further information is requested label Dec 2, 2018
@mhadziabdic
Copy link
Collaborator

Dear Boki,

As far as I can see vorticity is correct in Calculate_Shear_And_Vorticity(grid), and I suggest to keep this one.

@Niceno
Copy link
Collaborator Author

Niceno commented Feb 7, 2019

I see that Calculate_Vorticity is called only before Spalart's models. I have no idea why would one make a differentiation. Do you maybe remember Muhamed?

To my memory, I believe that I introduced Calculate_Vorticity while working on my thesis. Muhamed might have been using this function for Spalart's models, later introduced his Calculate_Shear_And_Vorticity for other advanced RANS models, but original Calculate_Vorticity just keeps hanging around.

Could that be the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants