Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with MPI_LOGICAL8 in development_branch #146

Open
palkinev opened this issue Oct 1, 2019 · 0 comments
Open

Issue with MPI_LOGICAL8 in development_branch #146

palkinev opened this issue Oct 1, 2019 · 0 comments
Assignees
@Niceno @DelNov
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@palkinev
Copy link
Collaborator

palkinev commented Oct 1, 2019 •
edited

I noticed the usage of MPI_LOGICAL8 type in Write_Log_Array and Read_Log_Array functions.

Although it agrees well with other 64-bit parameters like MPI_INTEGER8, but this is an exception.

This logical type was added in OpenMPI lib in 1.3 version [7 years ago], but it is not yet present in MPICH lib at all, not even in the newest 3.3 version.

Thus, I strongly discourage any usage of MPI_LOGICAL2, MPI_LOGICAL4, MPI_LOGICAL8, but
MPI_LOGICAL is present everywhere and I advice to use that instead (or MPI_INTEGER8).

Otherwise we are going to loose mpich users.
@palkinev palkinev added bug Something isn't working invalid This doesn't seem right labels Oct 1, 2019
@palkinev palkinev changed the title MPI_LOGICAL8 in development_branch Issue with MPI_LOGICAL8 in development_branch Oct 1, 2019
@palkinev palkinev mentioned this issue Oct 7, 2019
Merged
palkinev added a commit to palkinev/T-Flows that referenced this issue Jan 13, 2020
@palkinev
This resolves issue DelNov#146 in development_branch
8efc1a6 
This commit substitutes mpi_logical functions with integer
analogues where needed.
@palkinev palkinev mentioned this issue Jan 13, 2020
Closed
palkinev added a commit that referenced this issue Mar 5, 2020
@palkinev
Revert "This resolves issue #146 in development_branch"
2fbac81 
This reverts commit 8efc1a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Niceno Niceno

@DelNov DelNov

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Niceno @palkinev @DelNov