Fix #112 - don't subset cpuinfo #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm (but we should fix the tests here) |
|
Ya ya, tests almost fixed here: #115 Except for a new fun bug re: installing ffmpeg on Mac. So when thats merged will rebase this over that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #112
hi mathis(es), lab(s), and friends, miss u. about to close up shop for the day and thought i'd tick through a few low hanging fruit notifs. hope u all are doing well :)
(bug caused bc
'brand'was replaced by'brand_raw'afterv5.0.0, so it seems like why not just get the whole thing and not worry about future naming changes since it's just for diagnostics anyway)