Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in mc_esm_gearnet #20

Open
hxu105 opened this issue Apr 1, 2023 · 3 comments
Open

error in mc_esm_gearnet #20

hxu105 opened this issue Apr 1, 2023 · 3 comments

Comments

@hxu105
Copy link

hxu105 commented Apr 1, 2023

Howdy, thank u for ur awesome work in Enhancing Protein Language Models with Structure-based Encoder and Pre-training. I am running the pretaining experiment now, and I am facing an issue of "Can't find atom_feature in features.atom". I paste the error statement below.

image

It seems like it cannot recognize the atom_feature: null or bond_feature: null. Do I need to change the source code for implementing these two arguments?

Any help will be grateful!

@Oxer11
Copy link
Collaborator

Oxer11 commented Apr 3, 2023

Hi! Thanks for your interest in our work.

The config atom_feature: null and bond_feature: null mean that we want to set atom_feature=None and bond_feature=None so as to avoid the contruction of atom and bond features. This should be recognized by yaml library. It's quite weird that your code tried to find atom_feature in features.atom. Have you ever changed the config file? If not, maybe you can first print the value of cfg.dataset.atom_feature in the pretrain.py.

@hxu105
Copy link
Author

hxu105 commented Apr 4, 2023

Hello, thanks for your response. I checked the atom_feature in the config, and it prints None
image
I also had one question in lazy mode, lazy mode is to load pdb file each time we call get_item function, however, the init will set up the self.data by loading the pickle file, so proteins have already existed in our dataset and taken some CPU memory. Why does lazy mode claim to save CPU cost?

@Oxer11
Copy link
Collaborator

Oxer11 commented Apr 5, 2023

This is weird. Have you faced the same issue when pre-training with GearNet-Edge instead of ESM-GearNet? Could you share the full log file with me?

I'm sorry that I haven't considered the lazy mode for CPU. Typically, we assume there is no .pkl file when using lazy mode. So maybe you can try to remove the .pkl file and the lazy mode should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants