Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 dims labels are incorrect for vector quantities #190

Open
jsoishi opened this issue Apr 25, 2022 · 1 comment
Open

HDF5 dims labels are incorrect for vector quantities #190

jsoishi opened this issue Apr 25, 2022 · 1 comment
Assignees
Milestone

Comments

@jsoishi
Copy link
Member

jsoishi commented Apr 25, 2022

Vector quantities output to HDF5 files are missing the dimension corresponding to vector/tensor component(s). Instead they currently skip that dimension, moving to the next one and leaving the trailing dimensions blank. Here's an example from a 2D velocity field.

u_dset = df['tasks/u']
for i in range(len(u_dset.shape)):
    print("dimension {} label: {}".format(i,u_dset.dims[i].label))
@jsoishi jsoishi self-assigned this Apr 25, 2022
@kburns
Copy link
Member

kburns commented May 31, 2022

With #196, the tensor axes are now skipped (no scales) so that the spatial scales are at least attached to the correct dimensions.

@kburns kburns added this to the 3.0.0 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants