Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU version #8

Open
kamo-naoyuki opened this issue Oct 31, 2019 · 3 comments
Open

CPU version #8

kamo-naoyuki opened this issue Oct 31, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@kamo-naoyuki
Copy link

Thank you for creating great library.
Would you support the CPU implementation in this library? It's not necessary, but I think more useful for comparing the performance, for example.

@DavidDiazGuerra
Copy link
Owner

Thanks for your feedback. I don't have plans to include a CPU implementation since I would need to program it from scratch; as far as I know, there is no way to compile CUDA code to run on CPU or anything like that. It is true that that it could be interesting for comparing the performance but making a vanilla implementation wouldn't be fair and writing an optimized CPU version would need more time than I have for this project.

For comparing the performance I took as reference this Python library: https://github.com/Marvin182/rir-generator and this Matlab library: http://www.eric-lehmann.com/fast_ISM_code/index.html

@kamo-naoyuki
Copy link
Author

I see.

I think it's enough useful even if it's not optimized implementation.
I imaged that the users would like to switch the mode between CUDA and CPU version, like pytorch.
The API of gpuRIR is different from the other CPU RIR-generator module,
so we need to write only a little more codes for it.

However, it's O.K If you don't have the plan. I'm lazy.
Thanks.

@DavidDiazGuerra DavidDiazGuerra added the enhancement New feature or request label Oct 31, 2019
@DavidDiazGuerra
Copy link
Owner

It's true that it would be nice having the option to switch between CUDA and CPU just like PyTorch does... maybe I do it in the future if I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants