Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MacOS Mojave Dark Mode #1

Open
gjsman opened this issue Apr 3, 2019 · 3 comments
Open

Support MacOS Mojave Dark Mode #1

gjsman opened this issue Apr 3, 2019 · 3 comments

Comments

@gjsman
Copy link

gjsman commented Apr 3, 2019

https://kevinchen.co/blog/support-macos-mojave-dark-mode-on-websites/

If you could support this, that would be great!

@David-Griffiths
Copy link
Owner

Agreed, this would be nice to have.

I'll add to the list.

@gjsman
Copy link
Author

gjsman commented Apr 5, 2019

@gjsman
Copy link
Author

gjsman commented Apr 6, 2019

I actually just semi-implemented this myself in my Nova site.

I copied-pasted the styles from the extension and wrapped them in the @media section from the blog post. It worked pretty well. The only thing that didn't work was that the slider said Dark Mode was off, and switching it on/off didn't do anything. Close, but not quite there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants