Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

city profiles should show a geographic aggregation level in between it and its country #114

Open
melteng opened this issue Feb 17, 2017 · 5 comments
Assignees

Comments

@melteng
Copy link

melteng commented Feb 17, 2017

Ex. "Gary," Indiana where apparently the Jackson 5 came from.

The page title (in the tab) should say Gary, Indiana (like on wikipedia).

Where is says "United States" underneath the big "Gary" profile title, it should say "Indiana, United States."

screenshot 2017-02-17 18 30 19

@alexandersimoes
Copy link
Contributor

I definitely agree, but this would require some extra data from @crisjf as well as a slightly altered database structure. Currently there is no concept of a "state level" geography. @melteng were you imagining this only for US cities? Or in the case of cities outside the US supporting the province or other mid-geographic component? For example, would the Belo Horizonte page say "Belo Horizonte, Minas Gerais, Brazil"?

@crisjf
Copy link

crisjf commented Feb 21, 2017

Getting this data for US cities is relatively easy, but as @alexandersimoes mentions, it would involve altering the database structure. How important is this?

@crisjf
Copy link

crisjf commented Feb 21, 2017

Maybe we can do it only for the US, since most of the characters are American born anyways?

@alexandersimoes
Copy link
Contributor

If you can send me a new cities.tsv file with a display_name or long_name field that would have "Chicago, Illinois" I can use that in the profile in some places.

Also, would it be possible to get the wikipedia URL slugs that they use as another field in that file?

If you update that file please annotate the wiki as well 😄 - https://github.com/MacroConnections/pantheon2/wiki/Places

@melteng
Copy link
Author

melteng commented Feb 21, 2017

@alexandersimoes @crisjf Hmm I do think having provincial/state info is useful in larger countries, plus it'd avoid the user having to click out of the site to google the city name. But yeah for now, let's do the US first. Then we can look at the data and see what other large countries have a lot of representation and should include regions/provinces?

@alexandersimoes alexandersimoes changed the title cities should also call out their country city profiles should show a geographic aggregation level in between it and its country Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants