Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo/GraphQL integration #1494

Open
lwasyl opened this issue Jun 23, 2023 · 4 comments
Open

Apollo/GraphQL integration #1494

lwasyl opened this issue Jun 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@lwasyl
Copy link

lwasyl commented Jun 23, 2023

Are you requesting automatic instrumentation for a framework or library? Please describe.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Apollo is a networking library, it'd be beneficial to trace its performance, like timings when fetching thing from cache, as well as tracings related to various requests and tags for the call (e.g. calls with APQ vs calls without APQ)

Describe the solution you'd like
an ApolloInterceptor implementation tracing as much as makes sense, as well as OkHttp interceptor that tracks Graphql-specific headers (if it doesn't do that yet)

Describe alternatives you've considered
Writing everything manually

Additional context
Add any other context or screenshots about the feature request here.

@lwasyl lwasyl added the enhancement New feature or request label Jun 23, 2023
@0xnm
Copy link
Contributor

0xnm commented Jun 26, 2023

Hello @lwasyl! Thanks for opening the feature request.

Indeed, we are aware of this quite common need and this is what we are currently working on. I cannot give any estimates right now, because apart of the GraphQL support in our SDK we need to do changes in our webapp in order to better visualize it, but I can say for sure that this feature will land in our SDK later this year.

@lwasyl
Copy link
Author

lwasyl commented Sep 21, 2023

I'll just point out that Apollo 4.x will also support Ktor backend — it'd be nice if DD integration also worked with it, and not only with OkHttp one
initial support PR: apollographql/apollo-kotlin#5142

@0xnm
Copy link
Contributor

0xnm commented Sep 22, 2023

Hello @lwasyl! Can you please tell us about your usage of Ktor - are you using the client in Kotlin Multiplatform Mobile project? Or your project is only for Android, without multiplatform capabilities?

@lwasyl
Copy link
Author

lwasyl commented Sep 22, 2023

Hey @0xnm I'm not using ktor backend yet, but when Apollo-Kotlin 4.x is out we'll definitely consider/evaluate it wrt performance. Multiplatform usage of Apollo-Kotlin is something on our radar but not in immediate plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants