-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support DbString in DapperAOT #119
Open
DeagleGross
wants to merge
13
commits into
DapperLib:main
Choose a base branch
from
DeagleGross:dmkorolev/dbstring
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
commented
May 24, 2024
public class DAP048 : Verifier<DapperAnalyzer> | ||
{ | ||
[Theory] | ||
[InlineData("[DapperAot(false)]")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to emit warning ONLY in DapperAOT mode
add Integration tests for dbstring (in a separate project Dapper.AOT.Test.Integration)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DbString
is a known type in Dapper and currently there is no dedicated support in DapperAOT for it.Current PR does 2 things regarding
DbString
:DbString
toDbValue
attribute.DbParameter
if one of parameter members isDbString
by setting.Value
,.Size
and.DbType
Implementation notes:
Dapper.AOT.Analyzers
which are copied to the output in separate folderInGeneration
PreGeneratedCodeWriter
), and included the generation context options inGenerateState
to have a control over which pre-generated types to include in the output. I decided to do in order to avoid writingDbStringHelpers
in the output even in those cases, whereDbString
is not even used (basically to have more clear output)Questions:
DbString
inUpdateParameters
? Do we need to call the same setup there, or just re-assigning value is fine?Closes #89