Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App crashes on nil bannerPosition when using .applyStyling #413

Open
PaulEhrhardt opened this issue May 8, 2023 · 1 comment
Open

App crashes on nil bannerPosition when using .applyStyling #413

PaulEhrhardt opened this issue May 8, 2023 · 1 comment

Comments

@PaulEhrhardt
Copy link

Setting custom title & subtitle fonts using .applyStyling(...) extension forces the lib to update its height via updateBannerHeight().
It then crashes because bannerPosition == nil when a rotation is detected 馃挘
Happens more often on iPad when resuming activity from the background and the app UI rotates when becoming active again.

I suggest bannerPosition should be treated optional to avoid force unwrapping.

Device: iPad/ iPhone
OS: iOS 16.x
@PaulEhrhardt
Copy link
Author

Hello, any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulEhrhardt