Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why disallow background color for custom views? #410

Open
nathansalaun-sofia opened this issue Mar 27, 2023 · 1 comment
Open

Why disallow background color for custom views? #410

nathansalaun-sofia opened this issue Mar 27, 2023 · 1 comment

Comments

@nathansalaun-sofia
Copy link

This line https://github.com/Daltron/NotificationBanner/blob/master/NotificationBanner/Classes/BaseNotificationBanner.swift#L194 prevents setting a background color when there is a custom view.

Is there any reason why this is necessary? Or is it just an artificial limitation?

When I remove the guard, the background color still seems to work fine.

@reshmaraghu
Copy link

I see a fix was proposed, but not accepted.
#341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants