Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationBannerQueue needs to depend on a protocol (Liskov principle) #402

Open
Nikoloutsos opened this issue Jan 4, 2023 · 0 comments

Comments

@Nikoloutsos
Copy link

I want to replace the NotificationBannerQueue with my own NotificationBannerPriorityQueue. But since the method declarations depend on this specific type NotificationBannerQueue I am unable of do it.

public func show(
        queuePosition: QueuePosition = .back,
        bannerPosition: BannerPosition = .top,
-       queue: NotificationBannerQueue = NotificationBannerQueue.default,
+       queue: AnyNotificationBannerQueue = NotificationBannerQueue.default,
        
    )

I am willing to open a PR for fixing this. What is your opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant