Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated definitions in headers #32

Open
roland-sipos opened this issue Jan 24, 2023 · 0 comments
Open

Duplicated definitions in headers #32

roland-sipos opened this issue Jan 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@roland-sipos
Copy link
Member

There are duplicated definitions of

#define RX_RING_SIZE 1024
#define TX_RING_SIZE 1024

#define NUM_MBUFS 8191
#define MBUF_CACHE_SIZE 250

EALSetup.hpp and DPDKDefinitions.hpp

We need to clean it up and stick with one. Also, these should be const expressions?
@roland-sipos roland-sipos added the bug Something isn't working label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roland-sipos