Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout-daq-package.py -p is not working #356

Open
ron003 opened this issue Mar 25, 2024 · 1 comment
Open

checkout-daq-package.py -p is not working #356

ron003 opened this issue Mar 25, 2024 · 1 comment

Comments

@ron003
Copy link

ron003 commented Mar 25, 2024

Seems:
-def checkout_commit(repo, commit, outdir, is_success_required):
+def checkout_commit(repo, commit, outdir, is_success_required = True):
may be needed.
I'll submit PR shortly.

@jcfreeman2
Copy link
Contributor

Thanks for the PR. However, it seems like using checkout-daq-package.py to check out a single package and not doing a version crosscheck (the arguments needed to reproduce the error) remains broken and there are deeper issues there to be fixed (e.g., the commit has the Python None value, breaking the result). I'll take a look when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants