Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: groupId can't be undefined on onCloseTab #840

Open
mortalYoung opened this issue Jan 5, 2023 · 0 comments
Open

bug: groupId can't be undefined on onCloseTab #840

mortalYoung opened this issue Jan 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mortalYoung
Copy link
Collaborator

Describe the bug

- IEditorService.onCloseTab(callback: (tabId: UniqueId, groupId?: UniqueId | undefined) => void): any
+ IEditorService.onCloseTab(callback: (tabId: UniqueId, groupId: UniqueId) => void): any

Versions

  • OS:
  • Browser:
  • Molecule: 1.3.0

To reproduce

Expected

Actually happening
@mortalYoung mortalYoung added the bug Something isn't working label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mortalYoung