Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdm_responder_lib cannot identify capability conflict of DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE for SPDM version 1.0 & 1.1 #329

Open
owen126315 opened this issue Jan 23, 2024 · 4 comments

Comments

@owen126315
Copy link

owen126315 commented Jan 23, 2024

I ran the spdm_responder_validator test case 7.1 with below Responder settings:

Requester

  • SPDM (as the setup function)
  • DATA_TRANSFER_SIZE = 256
  • MAX_SPDM_MSG_SIZE = 0x1200 (this is conflict with DATA_TRANSFER_SIZE)

Responder

  • SPDM 1.3
  • DATA_TRANSFER_SIZE = 256
  • MAX_SPDM_MSG_SIZE = 0x1200
  • CHUNK_CAP = 1

The libspdm_get_response_capabilities seems cannot detect the conflict while handling get capability.
How should the responder handle this?

@owen126315 owen126315 changed the title Questions for capability agreement between SPDM requester and responder spdm_responder_lib cannot identify capability conflict for DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE for SPDM version 1.0 & 1.1 Jan 23, 2024
@steven-bellock
Copy link
Contributor

What SPDM version(s) does the Requester support? If it's the https://github.com/DMTF/SPDM-Responder-Validator then it cannot talk to a 1.3-only Responder since we haven't updated Responder Validator to 1.3 yet.

@owen126315 owen126315 changed the title spdm_responder_lib cannot identify capability conflict for DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE for SPDM version 1.0 & 1.1 spdm_responder_lib cannot identify capability conflict of DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE for SPDM version 1.0 & 1.1 Jan 24, 2024
@owen126315
Copy link
Author

The problem still here even responder is 1.2.

@owen126315
Copy link
Author

I guess the root cause is can both requester and responder support chunk, not SPDM version. the DATA_TRANSFER_SIZE and MAX_SPDM_MSG_SIZE must be equal if chunk is not support.
And libspdm_get_response_capabilities never check these two parameters when request.version = 1.0.

@steven-bellock
Copy link
Contributor

Those two fields, and chunking, did not exist until SPDM 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants