Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently CI will not run the unit test test_spdm_vendor_cmds for VENDOR_DEFINED_REQUEST and VENDOR_DEFINED_RESPONSE. #2677

Closed
Zhiqiang520 opened this issue Apr 25, 2024 · 2 comments · Fixed by #2687
Assignees
Labels
test For tests and testing infrastructure

Comments

@Zhiqiang520
Copy link
Contributor

Zhiqiang520 commented Apr 25, 2024

Currently CI will not run the unit test test_spdm_vendor_cmds for VENDOR_DEFINED_REQUEST and VENDOR_DEFINED_RESPONSE.
https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_vendor_cmds/test_spdm_vendor_cmds.c

- name: Test Requester
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_requester
- name: Test Responder
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_responder
- name: Test Common
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_common
- name: Test SPDM Crypt
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU'&& matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_crypt
- name: Test Crypt
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_crypt
- name: Test Secured Message
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_secured_message
- name: Test FIPS
if: matrix.toolchain != 'LIBFUZZER' && matrix.toolchain != 'ARM_GNU' && matrix.configurations == '-DLIBSPDM_RECORD_TRANSCRIPT_DATA_SUPPORT=1 -DLIBSPDM_FIPS_MODE=1' && matrix.configurations != '-DDISABLE_TESTS=1'
run: |
cd build/bin
./test_spdm_fips

- name: Test Requester
run: |
cd build/bin
./test_spdm_requester
- name: Test Responder
run: |
cd build/bin
./test_spdm_responder
- name: Test Common
run: |
cd build/bin
./test_spdm_common
- name: Test Cryptography
run: |
cd build/bin
./test_spdm_crypt
- name: Test FIPS
run: |
cd build/bin
./test_spdm_fips

@steven-bellock steven-bellock added the test For tests and testing infrastructure label Apr 25, 2024
@jyao1
Copy link
Member

jyao1 commented Apr 26, 2024

Can we just merge it into test_spdm_requester or test_spdm_responder?

@steven-bellock
Copy link
Contributor

Yes, they really don't need to be their own executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test For tests and testing infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants