Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspdm_gen_x509_csr() wrap the code with crypto support algorithm #2481

Open
rw8896 opened this issue Dec 16, 2023 · 1 comment
Open

libspdm_gen_x509_csr() wrap the code with crypto support algorithm #2481

rw8896 opened this issue Dec 16, 2023 · 1 comment
Assignees

Comments

@rw8896
Copy link
Contributor

rw8896 commented Dec 16, 2023

https://github.com/DMTF/libspdm/blob/2756b67e0fcdee9abf8de109092255c83e9256ca/os_stub/cryptlib_mbedtls/pk/x509.c#L1981C1-L1981C40

Hi,

I wonder if we should rearrange the code and wrap it with corresponding crypto support options?

For example,
#if LIBSPDM_RSA_SSA_SUPPORT
case LIBSPDM_CRYPTO_NID_RSASSA2048:
case LIBSPDM_CRYPTO_NID_RSASSA3072:
case LIBSPDM_CRYPTO_NID_RSASSA4096:
#endif
#if LIBSPDM_RSA_PSS_SUPPORT
case LIBSPDM_CRYPTO_NID_RSAPSS2048:
case LIBSPDM_CRYPTO_NID_RSAPSS3072:
case LIBSPDM_CRYPTO_NID_RSAPSS4096:
#endif

Thanks!

@steven-bellock
Copy link
Contributor

@rw8896 Sure. Feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants