Fix OSError when piping output of rf_logs.py #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraineri
reviewed
Mar 13, 2020
| finally: | ||
| redfish_obj.logout() | ||
| sys.stderr.close() |
There was a problem hiding this comment.
Can this be brought into the lower level print routine? I'd rather not create a burden on callers doing this since the "redfish_utilities" folder is supposed to be treated as a library others might use.
There was a problem hiding this comment.
I moved the catch of BrokenPipeError to print_log_entries(). But I left the sys.stderr.close() here because that seemed to be the only way to eliminate this extraneous message when piping to head:
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='UTF-8'>
BrokenPipeError: [Errno 32] Broken pipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OSError when piping the output of rf_logs.py as described in issue #32.
Fixes #32