Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Comparison" tests can show invalid failure if a property is not present #193

Closed
mraineri opened this issue Jan 8, 2024 · 0 comments
Closed

Comments

@mraineri
Copy link
Contributor

mraineri commented Jan 8, 2024

Some comparison testing will incorrectly report failures for properties that are not present, even if the property is not required. For example:

...
    "Chassis": {
        "PropertyRequirepments": {
            "ChassisType": {
                "ReadRequirement": "Recommended",
                "Comparison": "Equals",
                "Values": [ "RackMount" ]
            }
        }
    }
...

In the above case, if a Chassis resource does not contain ChassisType, an error regarding the comparison is reported. This should be corrected to report "Not Tested". The same issue applies with other types of comparisons. However, a simple "don't perform comparison" type of approach here isn't correct either since some of the comparisons are specifically testing presence/absence of a property.

@mraineri mraineri closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant