Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Cancel downloading instantly after pressing stop #53

Open
DarkVoyage opened this issue Sep 11, 2023 · 2 comments
Open

[Enhancement] Cancel downloading instantly after pressing stop #53

DarkVoyage opened this issue Sep 11, 2023 · 2 comments
Labels
Enhancement Enhancement of existing functionality

Comments

@DarkVoyage
Copy link

DarkVoyage commented Sep 11, 2023

馃悶 Bug Report

Describe the bug

If you cancel download, it will be cancelled only after last transfer is finished. Job should be cancelled right away.


Is this a regression?

It always worked like that.


To Reproduce

  1. Start downloading any album.
  2. Click on 'Stop'
  3. It will stop only after fully downloading current track.

Additional context

Sometimes connection gets very slow or disconnected. This behavior leads to situation, when track is downloading forever and you can't cancel the whole job because of it. Only closing whole downloader helps.

@DJDoubleD DJDoubleD changed the title [Bug] Cancel downloading instantly after pressing stop [Enhancement] Cancel downloading instantly after pressing stop Sep 11, 2023
@DJDoubleD
Copy link
Owner

This isn't a bug as it is clearly mentioned as intended behavior in the release notes of the version in which the stop feature was introduced:

If a track is in the middle of being downloaded when the button is pressed, the job will stop right after this last track download has completed.

So reclassified as possible enhancement.

@DJDoubleD
Copy link
Owner

Adding context from duplicate issue #66 by @zjgmijg

image When downloading, this can be made selectable and can be positioned with the mouse. In this way, enter can directly download again, which is very convenient.

As shown in the picture, the mouse can be positioned, so even if the card owner stops moving, I can enter and download directly.

Here the same feature is requested in order to solve network problems that would cause downloads to "hang".
And instant cancel option would save the user from having to restart the application, remove partially downloaded files and restart download of the canceled link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants