Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG?: Cardinal does not notify host of patch changes, allowing host to exit without warning user of unsaved changes. #631

Open
taji opened this issue Mar 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@taji
Copy link

taji commented Mar 31, 2024

Host: Reaper v6.34
Cardinal: 23.10
Pop OS (Linux)

To reproduce:

  • Add cardinal as a VST in Reaper.
  • Save the Reaper project (RPP) file.
  • Add a module to the patch bay in the Cardinal VST instance.
  • Close the reaper project (without saving).
    EXPECTED: Reaper (or any other host) should be aware that the plugin has changed and should emit a dialog to warn that your changes haven’t been saved.
    ACTUAL: Reaper exits without emitting warning. Your changes are now lost.

NOTE: Following the steps above in VCV will cause Reaper to warn you before exiting. I think the difference is that when adding a module, VCV is updating a VST parameter and notifying Reaper of the change. This way Reaper knows to warn the user that his changes are unsaved.

@taji
Copy link
Author

taji commented Apr 27, 2024

An update:

  • I tested Cardinal version 24.04 and am seeing the following:
  • If I add a module without connecting it to another module then Reaper still exits without warning
  • But if I wire the module to another module, Reaper emits the warning.

So my thinking is that this issue is now fixed to the point where it mostly works. You can close this issue as resolved.

@dromer
Copy link
Collaborator

dromer commented Apr 27, 2024

We didn't change anything to this regard.

Did you perhaps connect the Host Params module, or something equivalent from the Cardinal Host modules?
These parameters register with the host when you connect them, so it could be that Reaper detected this and now will warn about changes made to the plugin.

@taji
Copy link
Author

taji commented Apr 28, 2024

@dromer , yes you are right. I did exactly that! I went back and tested again with just a simple LFO into SCOPE and the problem is still there. So I guess we keep it open? I am happy to test if/when you have a fix for this.

@dromer dromer added the enhancement New feature or request label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants