Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiModel-MultiObs match fails with DummyModelResult #433

Open
jsmariegaard opened this issue Apr 11, 2024 · 0 comments
Open

MultiModel-MultiObs match fails with DummyModelResult #433

jsmariegaard opened this issue Apr 11, 2024 · 0 comments

Comments

@jsmariegaard
Copy link
Member

In my case I have multiple DfsuModelResults that I am matching with multiple observations

 cc = ms.match(obs_list, mr_list)

It goes fine, until I added a DummyModelResult to the mr_list. I assume that it should be enough to add DummyModelResult to the safe list below.

ValueError Traceback (most recent call last)
Cell In[26], line 1
----> 1 cc = ms.match(obs, mrs)
2 cc

File ~\Source\modelskill\modelskill\matching.py:255, in match(obs, mod, obs_item, mod_item, gtype, max_model_gap, spatial_method)
253 if len(obs) > 1 and isinstance(mod, Collection) and len(mod) > 1:
254 if not all(isinstance(m, (DfsuModelResult, GridModelResult)) for m in mod):
--> 255 raise ValueError(

@jsmariegaard jsmariegaard changed the title MultiModel-MultiObs match fails if MultiModel-MultiObs match fails with DummyModelResult Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant