Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug spatial_skill default binning #43

Open
Hendrik1987 opened this issue Apr 22, 2021 · 2 comments · May be fixed by #395
Open

minor bug spatial_skill default binning #43

Hendrik1987 opened this issue Apr 22, 2021 · 2 comments · May be fixed by #395

Comments

@Hendrik1987
Copy link
Contributor

https://github.com/DHI/fmskill/blob/686b146b776ec948dd44398ee736ca8df2aaa1a5/fmskill/compare.py#L611
Better: np.mean([np.min(x),np.max(x)])?

@jsmariegaard
Copy link
Member

Could you explain what the problem is?

@jsmariegaard jsmariegaard changed the title minor bug spatial_sill default binning minor bug spatial_skill default binning Apr 22, 2021
@Hendrik1987
Copy link
Contributor Author

Currently, the default spatial bins will be with respect to the mean x and y of the available track data ('center of gravity'). For the global data for example, this results in default bins, which are not centered near x=0, but shifted to the west (less data for longitudes from 0 to 180 degrees than from -180 to 0 degrees). In the global example this is not visible as the bins are specifically defined.

As suggested above, I think it would be nice to instead use the mean of the extend of the data (center of bounding box of data).

Even nicer would be to use the center of the bounding box of the domain. However, the domain is not always available.

@ecomodeller ecomodeller linked a pull request Jan 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants