Add WillCompleteOnCancel expectation #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting up the scenario where the context is cancelled but the database still completes the query without error. Some databases (eg. Postgres) do not guarantee that a query will be cancelled when the cancellation signal is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #299
I nerd-sniped myself after writing up the issue and started looking into the code. Turned out to be pretty straight-forward. So here's a PR! I hope you think it's useful. If you decide to merge this I would certainly pull this update and use this feature to write some new tests.
The goal of
.WillCompleteOnCancel()is to be able to test a pretty rare edge case in Postgres (and maybe other databases?) where the Go context is cancelled but due to timing, may not succeed in actually cancelling the query. In this case the query completes without error, and functions likeQueryContext()et al. do not return the "context canceled" error we normally expect.This change is fully backward-compatible. There is no change to the default behavior which is to return
ErrCancelledwhen the context is cancelled.