Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for the new maintainers #230

Open
l3pp4rd opened this issue Jun 21, 2020 · 28 comments
Open

Looking for the new maintainers #230

l3pp4rd opened this issue Jun 21, 2020 · 28 comments
Labels
help-wanted looking for help from open-source contributirs

Comments

@l3pp4rd
Copy link
Member

l3pp4rd commented Jun 21, 2020

I do not have much spare time for this library and willing to transfer the repository ownership to person or an organization motivated to maintain it. Open up a conversation if you are interested.

2020-06-21-165041

@morningvera
Copy link
Collaborator

hey @l3pp4rd, i've used this library for a while and i'm potentially interested in maintaining it! i created a project called eris that has picked up a little bit of steam over the past six months. it's relatively stable right now though, so i have bandwidth and energy to work on something else. i'm going to submit a PR for one of the open issues in the near future so i can get a better sense of the code (let me know if you have any suggestions).

@kachan1208
Copy link
Collaborator

I'm not that active person in worldwide community and can't show any public go repository where I've contributed something. But as starting point in "open source career building" it would be nice to help somebody to maintain this package if you don't mind.

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Aug 11, 2020

@morningvera @kachan1208 I've gave you the write access. This repository is active, but maintenance is minimal, since it integrates the standard sql interface. At the moment it is compatible with most of sql interface features needed for mocking, but some of the parts can be improved, like for example:

  1. the error messages. they could point to exact position in query string if it is not matching. and in general could be more user friendly.
  2. At the moment, I've made a mistake by making this Sqlmock as an interface instead of the plain struct type. But it may break backward compatibility, so my suggestion is to only change it with other backward incompatible changes for V2
  3. not sure if Column metadata needed manages all the cases needed for mocking. but since users do not complain, probably it is good enough as it is.
  4. people often ask about integration of the custom data types. This is not that simple and it comes with ValueConverter configuration through options. it could be documented or the integration itself could be simplified.
  5. there are many wanting the repeated query matching. but this may need the overall approach refactoring, probably it could come in V2 also.
  6. for V2. the general DSL for mocking could probably be well thought and simplified.

V2 related things are big and may require much work. So my suggestion for maintainers is to do something in the smallest backward compatible incremental steps. This way it is possible to finish something in meaningful time. Doing big chunks of changes usually decreases the motivation, too big changes are hard to commit and move on.

Other than that, sometimes people ask questions or open some issues, this also can be taken care. Though, do not commit for too much, limit the time you wish to spend weekly and do it in small incremental steps.

Thank you, for being active community members, since there are many users of this library, I'm sure the feedback you get, will be pleasant and impactful.

@rmulley
Copy link
Collaborator

rmulley commented Aug 18, 2020

@l3pp4rd I'm interested in helping maintain this library if you are still looking for people. I've been looking for ways to get involved in maintaining open source projects and this looks like a great fit. I have years of golang experience and have used this library successfully in several projects.

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Aug 21, 2020

Invites where sent for write access @rmulley @morningvera thanks for joining!

@morningvera
Copy link
Collaborator

Hey @l3pp4rd, I somehow missed this invite. Would you mind resending it? Thanks for all the advice above!

@gold-kou
Copy link
Collaborator

gold-kou commented Sep 6, 2020

@l3pp4rd

I'm just looking for OSS which I can contribute.
I've used sqlmock over 1 year and opened the tech blog about this package to the public.
Unfortunately, it is written in Japanese.
https://qiita.com/gold-kou/items/cb174690397f651e2d7f

Can I become a member? ✨

Thank you.

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Sep 6, 2020

Thanks @gold-kou invitation is open

@gagantrivedi
Copy link
Collaborator

hey, @l3pp4rd

I just started using this library and I am really impressed by the code quality of this project(kudos to you for that), and would love to maintain it (if the invitations are still open).

Thanks

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Sep 28, 2020

Thanks @gagantrivedi the invite is open and was sent

@asahasrabuddhe
Copy link
Collaborator

@l3pp4rd We are using this library at lot at work and I would like to lend my support in keeping it alive.

@gnagel
Copy link
Collaborator

gnagel commented Jul 4, 2021

@l3pp4rd I'm now using this library at lot and would like to help out too.

@theodesp
Copy link
Collaborator

theodesp commented Nov 29, 2021

Hello there. I'm also interested in helping here. Is there a Contributing.md document available so that new people like me can get up to speed with submitting PRs?

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Dec 1, 2021

you are welcome @theodesp we do not have contribution guide, but feel free to do whatever you want and think is worth in doing.

@Ghvstcode
Copy link
Collaborator

Hey @l3pp4rd, I love this library. If you’re still searching for maintainers, I am available.

@JessieAMorris
Copy link
Collaborator

I'd be interested in joining as a maintainer. Its seems like the v2 branch has decayed a bit though there's some valuable bits in that branch, especially with regard to null value handling. Looking to start chugging through some of the PRs as well.

@fatelei
Copy link
Collaborator

fatelei commented Jun 2, 2022

hi @l3pp4rd, i use the library, If you’re still searching for maintainers, I am available.

@l3pp4rd
Copy link
Member Author

l3pp4rd commented Jun 23, 2022

@Ghvstcode @JessieAMorris @fatelei have included you as contributors, thanks. sorry for late response

@pandrey2003
Copy link
Collaborator

@l3pp4rd Hey Gediminas! I'm a big fan of this library and would like to become its contributor 🙂

@developerasun
Copy link
Collaborator

@l3pp4rd hi! Just saw README and would like to participate in contribution.

@developerasun developerasun pinned this issue Oct 10, 2022
@othalla
Copy link

othalla commented Nov 19, 2022

Hey @l3pp4rd,
We're using sqlmock at OVHcloud. The library works like a charm and it's pretty stable.
I would like to help by:

  • upgrading to go1.19
  • adding golangci-lint
  • releasing a 1.6.0 with below improvements

Would it be possible?

@mstrYoda
Copy link
Collaborator

Hi all 👋

I am organizer of Go Turkey community. We will be happy to contribute this repository.

Also, I am personally contributed couple of OS projects written in Golang (Swaggo, Fiber, gocb, kustomize, DAPR) and I would like to work on this one too, can you invite me? Thank you 🙏

@ninadingole
Copy link
Collaborator

Would be happy to contribute to this lib, I am also extensively using this in my projects and have few feedbacks

@xuantianyingjie
Copy link
Collaborator

Hi, I'd love to contribute to this library, I use it in my project and think it's awesome, and I have time

@l3pp4rd l3pp4rd added the help-wanted looking for help from open-source contributirs label Jun 7, 2023
@filikos
Copy link
Collaborator

filikos commented Jul 24, 2023

Hey @l3pp4rd ,

I'm looking forward to contributing to this repository, with a focus on improving user experience and reducing friction. Working with the framework should not distract from the actual code that is getting tested.

Specifically:

1 . the error messages. they could point to exact position in query string if it is not matching. and in general could be more user friendly.

@trzysiek
Copy link
Collaborator

Hi @l3pp4rd
In my company we use this project a lot, we're very thankful for creating it! However we see some limitations, some very crucial for us. Could I ask for right to contribute?
I'm not sure if I'll have much time, but I might tackle some issues not concerning us, trying to show our gratitude for the repo.

@trzysiek
Copy link
Collaborator

trzysiek commented Apr 3, 2024

@l3pp4rd Invite once again please, it expired :(

@diegommm
Copy link

Hi @l3pp4rd ! Thank you very much for your work, I've been using this great library a lot and would like to contribute back. I have seasons where I have some spare time and I'm willing to start working with open issues and doing small contributions, then work with the rest of the team to see if we want/have time to move forward with something else.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted looking for help from open-source contributirs
Projects
None yet
Development

No branches or pull requests