Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a proper all-reduce algorithm for ObjGroup #2240

Open
lifflander opened this issue Jan 17, 2024 · 0 comments · May be fixed by #2272
Open

Use a proper all-reduce algorithm for ObjGroup #2240

lifflander opened this issue Jan 17, 2024 · 0 comments · May be fixed by #2272
Assignees
@JacobDomagala
Labels
type: task
Milestone
Add new allreduce

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Right now, proxy.allreduce is a reduce followed by a broadcast. We can make this more efficient by combining them into a singular allreduce algorithm.
JacobDomagala added a commit that referenced this issue Mar 24, 2024
@JacobDomagala
#2240: Initial work for new allreduce
937ef48
JacobDomagala added a commit that referenced this issue Apr 4, 2024
@JacobDomagala
#2240: Initial work for new allreduce
4788932
JacobDomagala added a commit that referenced this issue Apr 4, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
e3e2b5c
JacobDomagala added a commit that referenced this issue Apr 4, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
637a1c1
JacobDomagala added a commit that referenced this issue Apr 7, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
8860acb
JacobDomagala added a commit that referenced this issue Apr 10, 2024
@JacobDomagala
#2240: Initial work for new allreduce
186fb44
JacobDomagala added a commit that referenced this issue Apr 10, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
5167b0d
JacobDomagala added a commit that referenced this issue Apr 10, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
96a0eda
JacobDomagala added a commit that referenced this issue Apr 10, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
193f6ed
JacobDomagala added a commit that referenced this issue Apr 10, 2024
@JacobDomagala
#2240: Initial work for adding recursive doubling allreduce algorithm
ce017d9
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Initial work for new allreduce
74513ce
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
29514af
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
0072997
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
a6d694e
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Initial work for adding recursive doubling allreduce algorithm
7534af9
JacobDomagala added a commit that referenced this issue Apr 11, 2024
@JacobDomagala
#2240: Make sure the order of reduce operations is correct
a3d10f6
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Initial work for new allreduce
ad79ef5
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
a526f19
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
db6d5b1
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
c647432
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Initial work for adding recursive doubling allreduce algorithm
e522593
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Make sure the order of reduce operations is correct
8306937
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Working Recursive doubling
3f8c7e8
JacobDomagala added a commit that referenced this issue Apr 15, 2024
@JacobDomagala
#2240: Working Recursive doubling
8414d43
@JacobDomagala JacobDomagala linked a pull request Apr 15, 2024 that will close this issue
Draft
@JacobDomagala JacobDomagala linked a pull request Apr 15, 2024 that will close this issue
#2240: Add Rabenseifner and Recursive doubling allreduce algorithms for ObjGroup #2272
Draft
JacobDomagala added a commit that referenced this issue Apr 16, 2024
@JacobDomagala
#2240: Code cleanup and make Rabenseifner work with any Op type
97a076a
JacobDomagala added a commit that referenced this issue Apr 16, 2024
@JacobDomagala
#2240: Code cleanup and make Rabenseifner work with any Op type
17cfcbd
@JacobDomagala JacobDomagala added this to the Add new allreduce milestone May 7, 2024
@JacobDomagala JacobDomagala changed the title Use a proper all-reduce algorithm for proxy.allreduce Use a proper all-reduce algorithm for ObjGroup May 7, 2024
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Initial work for new allreduce
3e4c78a
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
1bf713b
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
22be7ce
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
1105b85
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Initial work for adding recursive doubling allreduce algorithm
803b53c
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Make sure the order of reduce operations is correct
22c7503
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Working Recursive doubling
81ba459
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Code cleanup and make Rabenseifner work with any Op type
dfa1a29
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
[#2240]: Improve accuracy of timing allreduce algorithms in allreduce.cc
cbb21e0
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Add unit tests for new allreduce and cleanup code
80d6712
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Improve accuracy of timing allreduce algorithms in allreduce.cc
dd33fd0
JacobDomagala added a commit that referenced this issue May 21, 2024
@JacobDomagala
#2240: Add unit tests for new allreduce and cleanup code
f01bad5
JacobDomagala added a commit that referenced this issue May 28, 2024
@JacobDomagala
#2240: DataHandler for Rabenseifner allreduce that provides common AP…
f870b61 
…I for various data types
JacobDomagala added a commit that referenced this issue May 28, 2024
@JacobDomagala
#2240: Fix warnings
f7e0f45
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Initial work for new allreduce
7ecc739
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Semi working Rabenseifner
132f05b
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Working Rabenseifner (non-commutative ops)
990a548
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Fix non power of 2 for new allreduce
3b0e933
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Initial work for adding recursive doubling allreduce algorithm
ea407f9
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Make sure the order of reduce operations is correct
be313f9
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Working Recursive doubling
23aa7d1
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Code cleanup and make Rabenseifner work with any Op type
0dd3fbd
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Improve accuracy of timing allreduce algorithms in allreduce.cc
aae0e1f
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Add unit tests for new allreduce and cleanup code
ec4d48a
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: DataHandler for Rabenseifner allreduce that provides common AP…
3c445d4 
…I for various data types
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Fix warnings
3836606
JacobDomagala added a commit that referenced this issue May 30, 2024
@JacobDomagala
#2240: Update ObjGroup test to use custom DataHandler for Rabenseifne…
ec6751d 
…r allreduce test
JacobDomagala added a commit that referenced this issue May 31, 2024
@JacobDomagala
#2240: Add unit test for Rabenseifner with Kokkos::View as DataType a…
e2adfdd 
…nd fix compile issues realted to using Kokkos::View for allreduce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
type: task
Projects
None yet
Milestone
Add new allreduce
Development

Successfully merging a pull request may close this issue.

#2240: Add Rabenseifner and Recursive doubling allreduce algorithms for ObjGroup DARMA-tasking/vt
2 participants
@lifflander @JacobDomagala