Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up collection_local_send #2155

Open
lifflander opened this issue May 30, 2023 · 0 comments
Open

Clean up collection_local_send #2155

lifflander opened this issue May 30, 2023 · 0 comments
Assignees

Comments

@lifflander
Copy link
Collaborator

We would like to clean up the collection_local_send performance test. Let's create one collection element per rank and then make sure we are sending locally from each rank to the element. We can query the map function or ask VT which elements are local to do this.

          @JacobDomagala @lifflander I'm trying to understand what the `collection_local_send.cc` perf tests actually do. Is it true that only rank `0` runs the timed perf test, and only does a send to collection element `0`, which is assumed to be local to rank `0` but not verified? It seems like some stuff could be simplified, like (a) consistently using `my_node_` instead of `theContext()->getNode()`, (b) also only pre-allocating on rank `0`, and (c) using `preallocate_` to conditionally pre-allocate based on what happened in `initialiaze` instead of having the separate `perfMakeRunnable` and `perfMakeRunnablePreAllocate` calls.

Originally posted by @nlslatt in #2097 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants