Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2154: Explore use of std::chrono for TimeType #2170

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

#2154: Explore use of std::chrono for TimeType #2170

wants to merge 2 commits into from

Conversation

JacobDomagala
Copy link
Contributor

Fixes #2154

@JacobDomagala
Copy link
Contributor Author

JacobDomagala commented Jun 21, 2023 •
edited

This branch for now consists of changes from https://github.com/DARMA-tasking/vt/tree/2168-use-loadtype-in-lb and https://github.com/DARMA-tasking/vt/tree/2150-use-strong-time-type with addition of using std::chrono for TimeType.

Work related to std::chrono was made in following commits:

@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from ecc6b9e to 362f533 Compare November 13, 2023 23:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 0afa389 (2023-12-20 23:47:03 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(202): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=vt::diagnostic::CounterDefaultType]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=vt::diagnostic::CounterDefaultType]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(112): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=double]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=double]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(113): here

/vt/src/vt/runtime/component/diagnostic_value.h(249): warning: missing return statement at end of non-void function "vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue [with T=vt::diagnostic::TimerDefaultType]"
          detected during instantiation of "T vt::runtime::component::detail::DiagnosticValueWrapper<T>::getComputedValue() const [with T=vt::diagnostic::TimerDefaultType]" 
/vt/src/vt/runtime/component/diagnostic_value.cc(114): here

/vt/src/vt/pipe/pipe_manager.impl.h(133): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

@JacobDomagala JacobDomagala marked this pull request as ready for review November 14, 2023 10:08
@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from 65e7938 to b77dc14 Compare November 14, 2023 13:28
@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from b77dc14 to f0996ca Compare November 21, 2023 17:28
@JacobDomagala JacobDomagala marked this pull request as draft November 21, 2023 17:30
@JacobDomagala JacobDomagala marked this pull request as ready for review November 24, 2023 08:28
@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from f0996ca to 145f344 Compare November 24, 2023 08:28
@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch 2 times, most recently from d5fdfe4 to ca4de2e Compare December 19, 2023 12:01
lifflander
lifflander approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JacobDomagala JacobDomagala force-pushed the 2154-explore-use-of-std-chrono-for-timetype branch from ca4de2e to 0afa389 Compare December 20, 2023 23:47
@JacobDomagala JacobDomagala self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@nmm0 nmm0 Awaiting requested review from nmm0

@thearusable thearusable Awaiting requested review from thearusable

@nlslatt nlslatt Awaiting requested review from nlslatt

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore use of std::chrono for time type
2 participants
@JacobDomagala @lifflander