Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed .online static domain #214

Closed
kam193 opened this issue Apr 13, 2024 · 1 comment
Closed

Missed .online static domain #214

kam193 opened this issue Apr 13, 2024 · 1 comment
Assignees
@cccs-kevin @cccs-jh @gdesmar
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working service-frankenstrings

Comments

@kam193
Copy link

kam193 commented Apr 13, 2024

Describe the bug
In a code (attached) there is a gTLD .online domain, which wasn't recognized during a static analysis. I know that with gTLDs the static detection is especially hard, so it's also a question if - according to AssemblyLine goals - such a domain should be recognized in a standard analysis (not the deep scan).

To Reproduce
Steps to reproduce the behavior:

  1. Upload the file with-online.zip (pass: zippy)
  2. Wait for analysis.
  3. Observe only .py found as a domain.
  4. Open the file and find the .online domain. In quite an important place, though.

Expected behavior
The .online domain is found during static analysis.

Screenshots

Environment (please complete the following information if pertinent):

  • Assemblyline Version: 4.5.0.12, FrankenStrings 4.5.0.3

Additional context
@kam193 kam193 added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Apr 13, 2024
@gdesmar gdesmar added accepted This issue was accepted, we will work on this at some point service-frankenstrings and removed assess We still haven't decided if this will be worked on or not labels May 17, 2024
@cccs-jh
Copy link

cccs-jh commented May 22, 2024

Hi, this is now fixed in FrankenStrings v4.5.0.6. It is intended to find domains with any valid TLD but frankenstrings was using an incomplete list of TLDs.

@cccs-jh cccs-jh closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cccs-kevin cccs-kevin

@cccs-jh cccs-jh

@gdesmar gdesmar

Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working service-frankenstrings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kam193 @cccs-kevin @cccs-jh @gdesmar