Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding related submissions doesn't work for supplementary files #199

Open
kam193 opened this issue Feb 23, 2024 · 1 comment
Open

Finding related submissions doesn't work for supplementary files #199

kam193 opened this issue Feb 23, 2024 · 1 comment
Assignees
Labels
assess We still haven't decided if this will be worked on or not bug Something isn't working

Comments

@kam193
Copy link

kam193 commented Feb 23, 2024

Describe the bug
If trying to find submissions related to a supplementary file, no submission is found. It looks like it's not really a problem in a normal flow (the only use case I find is to look for other submissions with the same supp. file, probably a rare case), but it's more painful in malware archive, which operates on files, not submissions - and thus, it's very useful to understand where a file comes from.

To Reproduce
Steps to reproduce the behavior:

  1. Open a submission with some results.
  2. Click on results details, and open the preview of any supplementary file (e.g. even ontology).
  3. Click on "Related submissions" button.
  4. Observe no submission found

OR

  1. Generate an archived submission with some supplementary files.
  2. Go to the archive, click on any supplementary file (again, even an ontology file).
  3. Click on "Related submissions" button.
  4. Observe no results.

Expected behavior
Related submissions are found.

Screenshots

Environment (please complete the following information if pertinent):

  • Assemblyline Version: 4.5.0stable4
  • Browser:Firefox
@kam193 kam193 added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Feb 23, 2024
@cccs-rs
Copy link
Contributor

cccs-rs commented Apr 9, 2024

This can be due to the fact that looking for "Related Submissions" will point you to the Submission index and supplementary files aren't included in the files field of a Submission, only files that seem to have been submitted.

Perhaps this could be amended to include supplementary files as well upon submission completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assess We still haven't decided if this will be worked on or not bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants