Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow Administrators to add tag types #182

Open
ociappara opened this issue Jan 25, 2024 · 4 comments
Open

Feature Request: Allow Administrators to add tag types #182

ociappara opened this issue Jan 25, 2024 · 4 comments
Assignees
Labels
assess We still haven't decided if this will be worked on or not enhancement New feature or request

Comments

@ociappara
Copy link

Assemblyline admins should be able to to extend the tags available in assemblyline through Values.yaml. This will allow context specific tags to be added without updating the main repository, giving users more control and customisations over their instance.

@ociappara ociappara added assess We still haven't decided if this will be worked on or not enhancement New feature or request labels Jan 25, 2024
@scottpas
Copy link

+1 for this. I would love to be able to add a tag which I could use as part of my alerting workflow (e.g. adding the tag to a yara rule that would indicate it's something I always want to receive an alert for)

@cccs-rs
Copy link
Contributor

cccs-rs commented May 16, 2024

What about mounting a custom tagging.py file to all containers on /var/lib/assemblyline/.local/lib/python3.11/site-packages/assemblyline/odm/models/tagging.py?

@ociappara
Copy link
Author

Not sure I understand?

@cccs-rs
Copy link
Contributor

cccs-rs commented May 17, 2024

Well you could basically fork the tagging.py which contains all the model validation for tags generated by services and mount them to the service containers via core.scaler.service_defaults.mounts.

In the Docker appliance, this could be a Docker volume mount and in Kubernetes, this could be saved in a ConfigMap that the pods will mount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assess We still haven't decided if this will be worked on or not enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants