Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG Symbols? #307

Open
mattzque opened this issue Nov 5, 2023 · 0 comments
Open

SVG Symbols? #307

mattzque opened this issue Nov 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mattzque
Copy link

mattzque commented Nov 5, 2023

Cool library, thanks!

I think it would be more efficient to use svg symbols, so like <svg><symbol id="dashboard">... somewhere centrally and then <svg><use xlink:href="#dashboard" /></svg> where the icon is used. In cases with lots of (the same) icons and server-side-rendering it can reduce the page size.

To accomplish this we could define a FaContext component that Fa components would talk to using the context API.

Any thoughts?
@Cweili Cweili added the enhancement New feature or request label Nov 13, 2023
@hawk93 hawk93 mentioned this issue Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cweili @mattzque