Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type 'other' includes both books and chapter / content items #86

Open
pdfeeney opened this issue Apr 1, 2019 · 2 comments
Open

type 'other' includes both books and chapter / content items #86

pdfeeney opened this issue Apr 1, 2019 · 2 comments

Comments

@pdfeeney
Copy link

pdfeeney commented Apr 1, 2019

We have 'other' as a type, but it includes both book and book child (chapter, usually). Other book / book child types are split out individually, these should be separated into separate types.

For example - this is registered as a book with book_type 'other':
http://api.crossref.org/works/10.5555/suffixtest

This is registered as a content_item (child of 'book') with component_type 'other' and also has type 'other' in the JSON:

http://api.crossref.org/works/10.4337/9781781001639.00001

@afandian
Copy link
Member

afandian commented Apr 2, 2019

Looking at http://api.crossref.org/works/10.5555/suffixtest

The relevant part of the XML says:

<content_item component_type="other">
  <titles><title>test item</title></titles>
  <doi_data>
    <doi>10.5555/suffixtest</doi>
    <resource>http://www.crossref.org/afds</resource>
  </doi_data>
</content_item>

So I think it's reasonable that Cayenne thinks that the content type is other:

"type": "other"

The Query result also includes this item outside of the query record:

<doi type="book_content">10.5555/suffixtest</doi>

This appears not to be part of the members-supplied metadata.

We can make the change to Cayenne, if appropriate, once we've documented the route that this data takes.

@ckoscher
Copy link
Contributor

ckoscher commented Apr 2, 2019

However, the tag that contains the @type (with value 'other') is

Generally when we speak of content type, we are referring to the major divisions in the schema (journal, book,conf/proc,dissertation,standard, database.. etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants