Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition Manager is broken for parition size bigger than 2GB!, because of the data type is int instead of ulong #2954

Open
COR-ET opened this issue Feb 19, 2024 · 4 comments

Comments

@COR-ET
Copy link

COR-ET commented Feb 19, 2024

Area of Cosmos - Partition of Disk and FileSystem (ManagedPartition is also related!)

Expected Behaviour - Partition bigger than int size (for example 2GB Partition) expected to work fine, so we can get correct BlockCount, Size, and use ReadBlock | WriteBlock

Actual Behaviour - The BlockCount is bigger than the Disk BlockCount 💀 , and ReadBlock or WriteBlock will give CPU heap (kernel unexpected crash)

Reproduction - After testing and analyzing.

Version - ofc DevKit and should be last month version.

image

@zarlo
Copy link
Member

zarlo commented Feb 19, 2024

i see no issue with the requested change of replacing the use of int to ulong in the VFS and fs drivers

fixed typo

@COR-ET
Copy link
Author

COR-ET commented Feb 20, 2024

@zarlo It would only increase from Max partition size from 2 GB to 4 GB wouldn't it ?

@zarlo
Copy link
Member

zarlo commented Feb 20, 2024

o i meant to put ulong

@funcieqDEV
Copy link

I have same

SzymekkYT added a commit to SzymekkYT/Cosmos-pre-releases that referenced this issue May 1, 2024
zarlo added a commit that referenced this issue May 5, 2024
Fixed maximum size of disks and partitions (issue #2954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants