Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner:test&golint fix #696

Merged
merged 2 commits into from Jul 20, 2020
Merged

Miner:test&golint fix #696

merged 2 commits into from Jul 20, 2020

Conversation

ShadowErii
Copy link
Contributor

No description provided.

This was linked to issues Jul 20, 2020
@ShadowErii ShadowErii removed a link to an issue Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #696 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   50.23%   49.69%   -0.54%     
==========================================
  Files         417      420       +3     
  Lines       52755    53380     +625     
==========================================
+ Hits        26500    26529      +29     
- Misses      24219    24815     +596     
  Partials     2036     2036              
Impacted Files Coverage Δ
miner/miner.go 0.00% <ø> (ø)
p2p/rlpx.go 69.40% <0.00%> (-2.55%) ⬇️
whisper/whisperv6/message.go 69.94% <0.00%> (-1.16%) ⬇️
rpc/handler.go 89.76% <0.00%> (-0.94%) ⬇️
ctxc/downloader/downloader.go 78.10% <0.00%> (-0.77%) ⬇️
rpc/client.go 80.98% <0.00%> (-0.71%) ⬇️
p2p/server.go 66.98% <0.00%> (ø)
miner/unconfirmed.go 70.83% <0.00%> (ø)
miner/worker.go 0.00% <0.00%> (ø)
... and 7 more

@ucwong ucwong requested review from ucwong and DhunterAO July 20, 2020 05:37
@ucwong ucwong merged commit 4a03a4d into master Jul 20, 2020
@ShadowErii ShadowErii deleted the ERII branch July 27, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golint fix
2 participants