[Bug] Incorrect reporting of reputation in stats

[JamesWP]

Describe the issue

The text describing the reputation goal for this level reads:

"Your reputation should not be less than 200. it is curently 457."
However the bar in the chart is at 10%

Steps to Reproduce

1. Load save game attached to this ticket

2. go to stats

Expected Behaviour

the graph should show at full height and green

Save Game

Save game attached to report: Yes

CorsixTH Version

0.67

Operating System

Windows 11

Theme Hospital Version

CD

Gamelog.txt

No response

Additional Information

save.zip

[JamesWP]

having increased my rep a bit now the column has disapeared:

[lewri]

I'm guessing there's only a lose condition on that level for reputation. What level is it?

I'm guessing that whatever threshold the lose condition measures against is saying you're 10% of the way to approaching 200 rep from some arbitrary number.

[JamesWP]

Not sure what the right way to refer to the level

[lewri]

Not sure what the right way to refer to the level

Level 6.

Probably shouldn't share the TH Level file data but essentially it says a lose condition is reputation below 200 with a bound of 500.
In other words, when your reputation dips below 500 it triggers the loss graph. This is intended behaviour.

However, we haven't implemented all the messages available at _A.level_progress. And _A.goals.lose only contains on string for one kind of loss (deaths). We should probably pad that out with new strings at some time.

[TheCycoONE]

This looks as designed right now, though I can see how it's confusing, especially if you're unfamiliar with lose conditions.

[MRMIdAS]

Surely the bar shouldn't be that low though. Yes it's under 500, fine, but it shouldn't be acting like he's on'y got a reputation of 10%, that's not how original TH behaved, the bars would actively show your progress. apparently it's out of 500, so 250 should be 50%, and his rep of 457 should be a smidge over 90%. the bar is incorrect, regardless of text.

[Alberth289346]

A screenshot from original TH may be useful here, I think. Mostly as guide to decisions.

It seems to me the confusion is from a different horizontal goal line. Positive goals seems to aim for the 100% line while negative goals seem to aim for the 0% line. Under that assumption, the small red bar is correct.
There is however no indication in the graph that tells the user what line is the goal.

I agree the problem is 90% solved.
A large bar of 90% would however send the wrong message I think. It then looks as-if you've got a major problem suddenly.

If all goals always use the 100% line as aim, would drawing a small bar down from the 100% line be more useful? The "100%" text becomes somewhat weird then, it's more a "goal reached" line.

Alternatively, it might help if besides the bar there is an indication what line the user should aim for.

Ideally I guess, it would need a -100 %-- +100% graph, so you can draw bars around the 0% in the middle.

[lewri]

We do need the originals implementation of the graph I agree to understand a bit better.

For reference to the red bar:
(Bound - Current) / (Bound - Min)
(500 - 457) / (500 - 200)
43 / (500 - 200)
43 / 300 = 0.1433
Multiply by 100 gives 14.33% on the way to the loss condition. The bar is actually closer to 20%.

There is no win condition for reputation to reflect on in comparison though. And even so if there was it wouldn't flip until the bound was met.

My suspicions until we get an original screenshot is TH took a creative shortcut with the graph and it uses fixed size increments when drawing rather than full accuracy. If that's the case we can probably fix that too if that's a problem.

[MandrakeHorse]

Here's a screenshot of the graph from Theme Hospital. This was taken on Level 6 with a reputation of 458:

[Alberth289346]

Thanks!

So TH does the same indeed. It is properly re-implemented thus.

The remaining question thus becomes whether to improve reading of the graph, and if so, how to do that.