[Bug] Right mouse panning can cause glitches with object placement

[lewri]

Describe the issue

Following on from #2375 -- we now need to address a small issue where enabling Right Mouse panning causes some little bugs on object placement:

1. When panning, the object will jitter around a little.
2. When you finish panning, the object will rotate 1 time onMouseUp.

The jitter I could live with for longer, the unintentional rotate is a little bit of a pain.

Steps to Reproduce

1. Start a game on a CorsixTH build on or after button for mouse panning can be toggled to be the middle or the right mouse button #2375
2. Set mouse panning to right mouse
3. Go into an object placement task and use panning to move around the view.

Expected Behaviour

We should avoid jittering of objects during a pan -- we also want to avoid unintentional rotation.

Save Game

Save game attached to report: No

CorsixTH Version

version with 2375 implemented (based on 0.67/master)

Operating System

Windows 10

Theme Hospital Version

GOG.com

Gamelog.txt

No response

Additional Information

No response

[lewri]

Wonder if we could make a secondary rotation to a keybind instead. Thus disabling right click rotation when it's used for panning.

Or we swap right button with middle button in addition too to support users who have a middle button on the mouse.

[lewri]

Wonder if we could make a secondary rotation to a keybind instead. Thus disabling right click rotation when it's used for panning.

This exists my bad: ingame_rotateobject = "space",

[lewri]

A new one: object pickup happens too if you try to pan while hovered on a selectable entity.