Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to use VCR or similar tools #71

Closed
pmayd opened this issue Mar 5, 2024 · 0 comments · Fixed by #99
Closed

Refactor tests to use VCR or similar tools #71

pmayd opened this issue Mar 5, 2024 · 0 comments · Fixed by #99
Assignees

Comments

@pmayd
Copy link
Collaborator

pmayd commented Mar 5, 2024

At the moment the tests mock the GENESIS API so we don't have to call it during tests.

But we don't have a good strategy how to do this or what to mock. We have some samples from GENESIS but not for all databases or rich variety.

We can use tools like vcr that can record API interactions and reply the data, making further requests offline. This could help us achieving better test coverage and more real test data.

TODOS:

  • decide about good test cases for all three databases
  • record interaction with vcr (pytest plugin!)
  • store files in repository
  • let tests use these files in the future
@pmayd pmayd self-assigned this Mar 19, 2024
@bergnerjonas bergnerjonas linked a pull request May 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants