Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic publish workflow on release #26 #69

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MarcoHuebner
Copy link
Collaborator

@MarcoHuebner MarcoHuebner commented Mar 5, 2024

Triggers on published release, independent from a git tag. Requires a hand-made release, which we will keep for now to be able to fully customize the release note content.

TODO: Investigate secrets and variables (security) to enable globally consistent python and poetry workflow versions

Resolves #26

Relies on variables PYTHON_VERSION and POETRY_VERSION to be defined in Settings/Secrets and Variables/Variables (Repository Variables)

#26
@MarcoHuebner
Copy link
Collaborator Author

MarcoHuebner commented Mar 11, 2024

Added global repository variables in workflows: vars.PYTHON_VERSION (should point to "3.10") and vars.POETRY_VERSION (should point to "1.6.1")

Note: Not 100% sure whether the work-around to fix json parsing ${{ vars.PYTHON_VERSION }} -> "${{ vars.PYTHON_VERSION }}" is going to cause problems - tbd

@pmayd
Copy link
Collaborator

pmayd commented Mar 12, 2024

So I have to create these env vars correct?

@pmayd
Copy link
Collaborator

pmayd commented Mar 12, 2024

I created the repository env vars that should be available now with vars.X:
image

@pmayd
Copy link
Collaborator

pmayd commented Mar 12, 2024

I rerun the pipeline and all jobs are green again!

@MarcoHuebner
Copy link
Collaborator Author

MarcoHuebner commented Mar 17, 2024

Thanks a lot! Can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Proper Release Workflow with Git Tags
3 participants